Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock.acquire() to respect blocking_timeout argument #499

Merged
merged 1 commit into from
Jun 19, 2014
Merged

Lock.acquire() to respect blocking_timeout argument #499

merged 1 commit into from
Jun 19, 2014

Conversation

grantcox
Copy link

This pull request fixes issue #498 . The blocking_timeout argument to Lock.acquire() had no effect, as only self.blocking_timeout was used when setting the stop_trying_at timeout value.

@grantcox grantcox mentioned this pull request Jun 19, 2014
Closed
andymccurdy added a commit that referenced this pull request Jun 19, 2014
@andymccurdy
Merge pull request #499 from grantcox/master
bd28b48 
Lock.acquire() to respect blocking_timeout argument
@andymccurdy andymccurdy merged commit bd28b48 into redis:master Jun 19, 2014
@andymccurdy
Copy link
Contributor

Good catch. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grantcox @andymccurdy